Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.2] Update the key generator on replay #8158

Merged
5 commits merged into from
Nov 5, 2021
Merged

[Backport 1.2] Update the key generator on replay #8158

5 commits merged into from
Nov 5, 2021

Commits on Nov 5, 2021

  1. fix(engine): update the key generator on replay 

    On replay, update the key generator with the replayed record's key. This
fixes an issue where the follower would restart with a snapshot where
nothing needed to be replayed, and would thus not update its generated
key, leading to processing starting with the wrong key and duplicate
keys, causing state inconsistencies.
    @npepinpe @Zelldon
    npepinpe authored and Zelldon committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    66eb002 View commit details
    Browse the repository at this point in the history

  2. test: adjust Cont. ReplayTest 

    Test should verify key column, to make sure on replay and processing key column family is filled.
    @Zelldon
    Zelldon committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    63412f1 View commit details
    Browse the repository at this point in the history

  3. test: add duplicated key IT test 

    Regression test which verifies that no duplicated keys are generated on the log, after fail over
    @Zelldon
    Zelldon committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6e27744 View commit details
    Browse the repository at this point in the history

  4. test: verify not emptiness

    @Zelldon
    Zelldon committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    9dcf828 View commit details
    Browse the repository at this point in the history

  5. test: make IT test 1.2 compatible 

    In order to work with the old transition logic, the regression test need to take snapshots so we restart from the snapshot and not replay the complete log on the new leader
    @Zelldon
    Zelldon committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    6b81b1d View commit details
    Browse the repository at this point in the history