Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: temporarily disable macos smoke tests for bors #8920

Merged
1 commit merged into from
Mar 16, 2022
Merged

Conversation

lenaschoenburg
Copy link
Member

Description

Temporarily disable the macOS smoke tests because there are a lot of failed bors runs due to a broken cache.

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Dunno if comments are fine like this in toml, but we'll find out!

I guess we should merge this directly then?

@lenaschoenburg
Copy link
Member Author

Dunno if comments are fine like this in toml, but we'll find out!

toml supports comments 😎

I guess we should merge this directly then?

Should be fine to merge with:

bors r+

@ghost
Copy link

ghost commented Mar 16, 2022

@ghost ghost merged commit 0efb893 into main Mar 16, 2022
@ghost ghost deleted the disable-macos-smoke-tests branch March 16, 2022 09:22
ghost pushed a commit that referenced this pull request Mar 16, 2022
8921: ci: a failing smoke test doesn't cancel other smoke tests r=npepinpe a=oleschoenburg

Whenever a smoke test failed, it cancelled other smoke tests. This
prevented us from easily disabling one smoke test in the bors conditions

Now we always run all smoke tests and don't cancel others on failure.

relates to #8920 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
ghost pushed a commit that referenced this pull request Mar 16, 2022
8921: ci: a failing smoke test doesn't cancel other smoke tests r=npepinpe a=oleschoenburg

Whenever a smoke test failed, it cancelled other smoke tests. This
prevented us from easily disabling one smoke test in the bors conditions

Now we always run all smoke tests and don't cancel others on failure.

relates to #8920 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants