Refactor protocol-jackson to use the new immutable protocol #8973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
force-pushed
the
8837-protocol-jackson
branch
3 times, most recently
from
80e2287
to
e0b2df0
Compare
korthout
approved these changes
Mar 25, 2022
protocol-jackson/src/main/java/io/camunda/zeebe/protocol/jackson/RecordMixin.java
Show resolved
Hide resolved
protocol-jackson/src/main/java/io/camunda/zeebe/protocol/jackson/ZeebeProtocolModule.java
Outdated
Show resolved
Hide resolved
protocol-jackson/src/main/java/io/camunda/zeebe/protocol/jackson/ZeebeProtocolModule.java
Show resolved
Hide resolved
korthout
approved these changes
Mar 25, 2022
protocol-jackson/src/main/java/io/camunda/zeebe/protocol/jackson/AnnotationIntrospector.java
Show resolved
Hide resolved
npepinpe
force-pushed
the
8837-new-protocol-util
branch
2 times, most recently
from
d8b0176
to
8078a32
Compare
npepinpe
force-pushed
the
8837-protocol-jackson
branch
from
fdc7ce1
to
c1d8ac5
Compare
Removes the old immutable `protocol-jackson`, and use the new one found directly in the `protocol` module. This completely changes how the module is used. The API is now to create a new `ObjectMapper` and register an instance of `ZeebeProtocolModule`, which knows how to serialize and deserialize records using the new immutable protocol. This is achieved by reusing the mapping utilities found in `protocol-util`.
npepinpe
force-pushed
the
8837-protocol-jackson
branch
from
c1d8ac5
to
854127d
Compare
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Mar 26, 2022
8973: Refactor protocol-jackson to use the new immutable protocol r=npepinpe a=npepinpe ## Description This PR updates the `protocol-jackson` module to make use of the new immutable protocol classes in `protocol`, using the `protocol-util` module to discover and map the abstract and concrete types together. As mentioned in the issue, the tests are somewhat minimal, but will be fleshed out as soon as the record factory is added in the next step. ## Related issues related to #8837 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
protocol-jacksonmodule to make use of the new immutable protocol classes inprotocol, using theprotocol-utilmodule to discover and map the abstract and concrete types together. As mentioned in the issue, the tests are somewhat minimal, but will be fleshed out as soon as the record factory is added in the next step.Related issues
related to #8837
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: