Mark DeployProcessCommand as deprecated for Go client #8997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
force-pushed
the
np-deprecate-go-api
branch
from
e65bfc6
to
e832b03
Compare
npepinpe
force-pushed
the
np-deprecate-go-api
branch
from
e832b03
to
b1060c4
Compare
|
bors merge |
|
/backport |
|
Successfully created backport PR #9002 for |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Mar 28, 2022
9002: [Backport release-8.0.0] Mark DeployProcessCommand as deprecated for Go client r=npepinpe a=github-actions[bot] # Description Backport of #8997 to `release-8.0.0`. relates to #8995 9007: [Backport release-8.0.0] Fix notification of snapshot replication listeners about missed events r=oleschoenburg a=oleschoenburg ## Description Manual backport of #8994 for the `8.0`release branch Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com> Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR marks
DeployProcessCommandas a deprecated method in the Go client, and also thezbctl deploy <processPath>...usage (to be replaced byzbctl deploy resource <resourcePath>...).Using the deprecated API in Go will trigger a warning (as you can see by our need to add
//nolintin places 😄)Related issues
related to #8995
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: