Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate ImmutableProcessInstanceRelated #9014

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Do not generate ImmutableProcessInstanceRelated #9014

merged 2 commits into from
Mar 30, 2022

Conversation

npepinpe
Copy link
Member

Description

ProcessInstanceRelated was mistakenly annotated with the immutable annotation, which caused us to generate an unnecessary class. This simply removes it, and adds a regression test.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

@npepinpe
refactor(protocol): do generate ImmutableProcessInstanceRelated
746b0fd 
Do not generate `ImmutableProcessInstanceRelated` as it is not a leaf
type, and does not need an immutable variant.
@npepinpe
test(protocol): add regression test
e354b74
@npepinpe npepinpe requested a review from korthout March 28, 2022 19:41
korthout
korthout approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@npepinpe
Copy link
Member Author

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 30, 2022
@zeebe-bors-camunda @npepinpe
merge: #9014
98d7517 
9014: Do not generate ImmutableProcessInstanceRelated r=npepinpe a=npepinpe

## Description

`ProcessInstanceRelated` was mistakenly annotated with the immutable annotation, which caused us to generate an unnecessary class. This simply removes it, and adds a regression test.



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

This PR was included in a batch that successfully built, but then failed to merge into main (it was a non-fast-forward update). It will be automatically retried.

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 30, 2022
@zeebe-bors-camunda @npepinpe
merge: #9014
ffa89dc 
9014: Do not generate ImmutableProcessInstanceRelated r=npepinpe a=npepinpe

## Description

`ProcessInstanceRelated` was mistakenly annotated with the immutable annotation, which caused us to generate an unnecessary class. This simply removes it, and adds a regression test.



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@npepinpe
Copy link
Member Author

bors merge

@korthout
Copy link
Member

This PR was included in a batch that successfully built, but then failed to merge into main (it was a non-fast-forward update). It will be automatically retried.

Sorry about that, my fault

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 4ea9a29 into main Mar 30, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the np-remove-annotation branch March 30, 2022 11:13
@github-actions github-actions bot mentioned this pull request Mar 30, 2022
Merged
@github-actions
Copy link
Contributor

Successfully created backport PR #9028 for release-8.0.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Mar 30, 2022
@zeebe-bors-camunda @npepinpe
merge: #9028
634da19 
9028: [Backport release-8.0.0] Do not generate ImmutableProcessInstanceRelated r=npepinpe a=github-actions[bot]

# Description
Backport of #9014 to `release-8.0.0`.

relates to 

Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Mar 30, 2022
@zeebe-bors-camunda @npepinpe
merge: #9028
bddd216 
9028: [Backport release-8.0.0] Do not generate ImmutableProcessInstanceRelated r=npepinpe a=github-actions[bot]

# Description
Backport of #9014 to `release-8.0.0`.

relates to 

Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korthout korthout korthout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@npepinpe @korthout @pihme