Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update to windows-latest in bors.toml #9046

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

remcowesterhoud
Copy link
Contributor

Description

In #8968 we have decided to upgrade from windows-2022 to windows-latest in our smoke-tests. In this change we forgot to update the the name in bors, causing bors to get stuck waiting for a check named "Smoke tests on windows-2022" to complete.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

In #8968 we have decided to upgrade from windows-2022 to windows-latest in our smoke-tests. In this change we forgot to update the the name in bors, causing bors to get stuck waiting for a check named "Smoke tests on windows-2022" to complete.
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Please merge it by hand.

@remcowesterhoud
Copy link
Contributor Author

Pfff manual labor 😮‍💨

@remcowesterhoud remcowesterhoud merged commit 81ef390 into main Apr 1, 2022
@remcowesterhoud remcowesterhoud deleted the bors-fix branch April 1, 2022 14:48
@korthout
Copy link
Member

korthout commented Apr 1, 2022

Thanks @remcowesterhoud 🙇

@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants