Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add junit engines to list of unused declared deps #9120

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

npepinpe
Copy link
Member

Description

This PR adds Junit engines to the list of unused and declared dependencies, as we often rely on these in our tests but never actually call on them directly, as they're test-runtime dependencies only.

Related issues

closes #9116

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Adds Junit engines to the list of unused and declared dependencies, as
we often rely on these in our tests but never actually call on them
directly, as they're test-runtime dependencies only.
@npepinpe npepinpe requested a review from pihme April 13, 2022 07:23
Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Apr 13, 2022
9120: Add junit engines to list of unused declared deps r=pihme a=npepinpe

## Description

This PR adds Junit engines to the list of unused and declared dependencies, as we often rely on these in our tests but never actually call on them directly, as they're test-runtime dependencies only.

## Related issues

closes #9116



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@npepinpe
Copy link
Member Author

Fairly certain this has nothing to do with the changes, and as nothing is running on bors, I will merge.

@npepinpe npepinpe merged commit 4d15012 into main Apr 13, 2022
@npepinpe npepinpe deleted the 9116-fix-dep-issues branch April 13, 2022 08:06
@deepthidevaki deepthidevaki added the version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 label May 3, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.0-alpha1 Marks an issue as being completely or in parts released in 8.1.0-alpha1 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency error when running mvn clean install
4 participants