Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log health status unnecessarily #9208

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Conversation

deepthidevaki
Copy link
Contributor

Description

  • Compare current and previous healthstatus instead of healthreport

Related issues

closes #9207

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deepthidevaki, looks good to me! 👍

The health status was logged everytime, because this check failed. We have to log the status only if there was a change, otherwise it is just noise in the logs.
@deepthidevaki
Copy link
Contributor Author

bors merge

@zeebe-bors-camunda
Copy link
Contributor

@github-actions
Copy link
Contributor

Successfully created backport PR #9212 for stable/1.3.

@github-actions
Copy link
Contributor

Successfully created backport PR #9213 for stable/8.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Apr 22, 2022
9213: [Backport stable/8.0] Do not log health status unnecessarily r=deepthidevaki a=github-actions[bot]

# Description
Backport of #9208 to `stable/8.0`.

relates to #9207

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Apr 22, 2022
9212: [Backport stable/1.3] Do not log health status unnecessarily r=deepthidevaki a=github-actions[bot]

# Description
Backport of #9208 to `stable/1.3`.

relates to #9207

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Apr 22, 2022
9213: [Backport stable/8.0] Do not log health status unnecessarily r=deepthidevaki a=github-actions[bot]

# Description
Backport of #9208 to `stable/8.0`.

relates to #9207

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Apr 22, 2022
9212: [Backport stable/1.3] Do not log health status unnecessarily r=deepthidevaki a=github-actions[bot]

# Description
Backport of #9208 to `stable/1.3`.

relates to #9207

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partition is healthy is logged unnecessarily
3 participants