Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a job backoff timeout on Zeebe Java client side #9389

Merged

Conversation

aivinog1
Copy link
Contributor

Description

I implemented the usage of the backoff parameter in the Zeebe Java Client and @saig0 fixed the problem with flushing responses.

Related issues

#5629

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@saig0 saig0 self-requested a review May 17, 2022 08:14
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aivinog1 thank you for your contribution 🎉
Looks all very well 👍

This enables a really cool feature. I'm looking forward to see it in action 🚀

@saig0
Copy link
Member

saig0 commented May 20, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit c04b75a into camunda:main May 20, 2022
@aivinog1 aivinog1 deleted the 5629-client-java-backoff-timeout branch May 23, 2022 04:00
@aivinog1 aivinog1 restored the 5629-client-java-backoff-timeout branch May 30, 2022 11:42
@aivinog1 aivinog1 deleted the 5629-client-java-backoff-timeout branch May 30, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants