Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Allow disabling environment variable override in Java client #9411

Merged
merged 2 commits into from
May 25, 2022

Conversation

berndruecker
Copy link
Member

@berndruecker berndruecker commented May 18, 2022

This would fix #9401, which is needed to reliably run test cases using zeebe-process-test or spring-zeebe.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I had just one small comment, but I don't think we need another review for that. Please address it and then go ahead and merge 🚀

@berndruecker berndruecker merged commit f7b8096 into main May 25, 2022
@berndruecker berndruecker deleted the java-client-disable-env-override branch May 25, 2022 13:13
@berndruecker
Copy link
Member Author

I was surprised not to see this in 8.0.3 - was there any reason not to include it (I would love to push it into spring-zeebe asap :-)) - maybe @npepinpe has an idea?

@npepinpe
Copy link
Member

npepinpe commented Jun 2, 2022

No, sorry, we just forgot to backport it. Normally we label PRs to be backported, so merging them causes it to be backported immediately, and I forgot to do it here.

@npepinpe
Copy link
Member

npepinpe commented Jun 2, 2022

removed maybe this stops the loop?

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

3 similar comments
@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

3 similar comments
@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@Zelldon
Copy link
Member

Zelldon commented Jun 2, 2022

Wow that was intense 😅

@npepinpe
Copy link
Member

npepinpe commented Jun 2, 2022

Whoa, not sure what's going on with the bot 😄 @korthout ?

@npepinpe
Copy link
Member

npepinpe commented Jun 2, 2022

I appreciate the enthusiasm though 😄

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

2 similar comments
@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

1 similar comment
@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

1 similar comment
@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

4 similar comments
@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/1.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf

zeebe-bors-camunda bot added a commit that referenced this pull request Jun 2, 2022
9488: [Backport stable/8.0] Allow disabling environment variable override in Java client r=remcowesterhoud a=npepinpe

## Description

This PR backports #9411 to 8.0.x. There was a single conflict on formatting, but nothing major.

## Related issues

backports #9411 
related to #9401 



Co-authored-by: Bernd Ruecker <bernd.ruecker@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Jun 2, 2022
9482: Release 1.3.9 r=remcowesterhoud a=npepinpe

## Description

This PR merges the release commits for 1.3.9.



9487: [Backport stable/1.3] Allow disabling environment variable override in Java client r=remcowesterhoud a=npepinpe

## Description

This PR backports #9411 to 1.3.x. I had to adapt it a little for 1.3, so please review (it's fairly small though).

## Related issues

<!-- Which issues are closed by this PR or are related -->

backports #9411 
related to #9401 



Co-authored-by: 180642 <ci@camunda.com>
Co-authored-by: Bernd Ruecker <bernd.ruecker@camunda.com>
@berndruecker
Copy link
Member Author

Wow - a lot of activity in this issue :-) Does that mean this should be finally in 8.0.4 - right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allows disabling environment variable override in JavaClient
4 participants