-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): Allow disabling environment variable override in Java client #9411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I had just one small comment, but I don't think we need another review for that. Please address it and then go ahead and merge 🚀
clients/java/src/main/java/io/camunda/zeebe/client/impl/ZeebeClientBuilderImpl.java
Outdated
Show resolved
Hide resolved
I was surprised not to see this in 8.0.3 - was there any reason not to include it (I would love to push it into spring-zeebe asap :-)) - maybe @npepinpe has an idea? |
No, sorry, we just forgot to backport it. Normally we label PRs to be backported, so merging them causes it to be backported immediately, and I forgot to do it here. |
removed maybe this stops the loop? |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
3 similar comments
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
3 similar comments
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Wow that was intense 😅 |
Whoa, not sure what's going on with the bot 😄 @korthout ? |
I appreciate the enthusiasm though 😄 |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
2 similar comments
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
1 similar comment
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
1 similar comment
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
4 similar comments
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/1.3
git worktree add -d .worktree/backport-9411-to-stable/1.3 origin/stable/1.3
cd .worktree/backport-9411-to-stable/1.3
git checkout -b backport-9411-to-stable/1.3
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-9411-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-9411-to-stable/8.0
git checkout -b backport-9411-to-stable/8.0
ancref=$(git merge-base 751140ff85ed7fd64e21cf348a948eb18e89ba05 63125fa8caad57bed4c1ad23e49a32f320972aaf)
git cherry-pick -x $ancref..63125fa8caad57bed4c1ad23e49a32f320972aaf |
9488: [Backport stable/8.0] Allow disabling environment variable override in Java client r=remcowesterhoud a=npepinpe ## Description This PR backports #9411 to 8.0.x. There was a single conflict on formatting, but nothing major. ## Related issues backports #9411 related to #9401 Co-authored-by: Bernd Ruecker <bernd.ruecker@camunda.com>
9482: Release 1.3.9 r=remcowesterhoud a=npepinpe ## Description This PR merges the release commits for 1.3.9. 9487: [Backport stable/1.3] Allow disabling environment variable override in Java client r=remcowesterhoud a=npepinpe ## Description This PR backports #9411 to 1.3.x. I had to adapt it a little for 1.3, so please review (it's fairly small though). ## Related issues <!-- Which issues are closed by this PR or are related --> backports #9411 related to #9401 Co-authored-by: 180642 <ci@camunda.com> Co-authored-by: Bernd Ruecker <bernd.ruecker@camunda.com>
Wow - a lot of activity in this issue :-) Does that mean this should be finally in 8.0.4 - right? |
This would fix #9401, which is needed to reliably run test cases using zeebe-process-test or spring-zeebe.
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.