9725 engine abstraction part 1 #9735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zelldon
approved these changes
Jul 7, 2022
- Add new package for classes that will fall into the scope of the platform - Implement arch unit test to check that no unwanted dependencies between packages exist
pihme
force-pushed
the
9725-engine-abstraction-part-1
branch
from
5961ebf
to
13c2775
Compare
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Jul 8, 2022
9735: 9725 engine abstraction part 1 r=pihme a=pihme ## Description - adds a new package into which the platform classes will be moved temporarily (with the idea to later move them into a new Maven module) - adds a test that warns about unwanted dependencies to that new package - moves some relevant classes into the new package - adds skeleton interfaces for the engine abstraction - implements replay functionality in new `Engine` class and calls the replay from the existing classes ## Related issues related to #9725 Co-authored-by: pihme <pihme@users.noreply.github.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Engineclass and calls the replay from the existing classesRelated issues
related to #9725
Definition of Done
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.