Notify checkpoint listeners after init and replay #9943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepthidevaki
changed the title
Test Results 799 files + 2 1 errors 798 suites +2 1h 35m 14s ⏱️ - 1m 15s For more details on these parsing errors, see this check. Results for commit afa7f09. ± Comparison against base commit c7debcc. ♻️ This comment has been updated with latest results. |
The listeners must be updated with the current checkpointId after init and replay. Otherwise if there are no new checkpoint created, after a restart or failover the listeners cannot know about the latest checkpoint. It is important for `InterPartitionCommandSender` and `InterPartitionCommandReceiver` to keep track of the latest checkpointId to guarantee that the checkpoints are consistent.
deepthidevaki
force-pushed
the
dd-9916-cp-listeners
branch
from
a71c706
to
e0198f7
Compare
oleschoenburg
requested changes
Aug 1, 2022
backup/src/main/java/io/camunda/zeebe/backup/processing/CheckpointRecordsProcessor.java
Show resolved
Hide resolved
backup/src/main/java/io/camunda/zeebe/backup/api/CheckpointListener.java
Show resolved
Hide resolved
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The listeners must be upddated with the current checkpointId after init and replay. Otherwise if there are no new checkpoint created, after a restart or failover the listeners cannot know about the latest checkpoint. It is important for
InterPartitionCommandSencerandInterPartitionCommandReceiverto keep track of the latest checkpointId to guarantee that the checkpoints are consistent.Related issues
closes #9916
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.