-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backwards-incompatible protocol version bump #9954
Conversation
Test Results 800 files ± 0 1 errors 799 suites ±0 1h 44m 37s ⏱️ + 10m 3s For more details on these parsing errors, see this check. Results for commit b757ceb. ± Comparison against base commit b3cff93. ♻️ This comment has been updated with latest results. |
@deepthidevaki So @npepinpe and I talked about potential tests a bit more and came to the conclusion that we don't need them for now. The reason is a mixture of
I'll create follow-up issues that will allow us to write acceptance tests in the future. |
To clarify, I think they would be hacky now because you would need to observe that compaction did not occur (since the exporter position is not propagated), and at the moment you need knowledge of the file system layout to do that. Hopefully we have better monitoring tools in the future and we can write such tests :) But Ole's main point stands, as this doesn't prevent rolling update (only possibly prevents compaction while an update is ongoing and also possibly generates error), this is probably not critical enough to warrant more effort 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for doing this 👍
bors r+ |
Build succeeded: |
Description
This splits the protocol based on usage and reverts the version bump in
protocol.xml
.Related issues
closes #9949
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.