-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generic properties as extension element #9955
Conversation
Allow to specify generic properties as extension elements in the Zeebe namespace. <bpmn:extensionElements> <zeebe:properties> <zeebe:property name="name1" value="value1" /> <zeebe:property name="name2" value="value2" /> </zeebe:properties> </bpmn:extensionElements> This change does not include any getter/setter or builder for properties as we expect them being used mainly by modeler users and have no execution semantic.
Test Results 803 files + 2 1 errors 802 suites +2 1h 37m 51s ⏱️ -8s For more details on these parsing errors, see this check. Results for commit 353a3ee. ± Comparison against base commit c7eccc4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@menski looks all good 👍
❌ But I would like to see an integration test. Since the properties will not be used in the engine itself, we should verify that we can read the properties from a given model. For example, building a BPMN with these extension elements and using the model API to read the properties. Otherwise, we don't realize if we can't read the properties as expected.
@saig0 I added a read test, please let me know if you think we should have a bigger/different test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@menski I like it 👍
bors merge
Build succeeded: |
Description
Allow to specify generic properties as extension elements in the Zeebe namespace.
This change does not include any getter/setter or builder for properties as we expect them being used mainly by modeler users and have no execution semantic.
Related issues
closes #9868
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.