[Backport stable/1.3] Don't overwrite local multi-instance variables #9957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the output element expression is a variable (or a nested property of a variable) then it needs to be nil initialized, to make sure that the variable exists at the local scope. However, when the output element expression refers to the same variable as the input element, then it shouldn't overwrite this variable. Note that the input variable is already created at the local scope. This adds a test case that fails if the output element variable is nil initialized when it refers to the same variable as the input element. (cherry picked from commit 75f567e)
When the output element expression is a variable (or a nested property of a variable) then it needs to be nil initialized, to make sure that the variable exists at the local scope. However, when the output element expression refers to the same variable as the input element, then it shouldn't overwrite this variable. Note that the input variable is already created at the local scope. We can simply filter out this case, and only nil init the other output element variables. (cherry picked from commit 1377cd6)
The zeebe extension property Output Element must be an expression. The method only exists to allow a test case that rejects a process when the output element is a static value. (cherry picked from commit debacc7)
When the output element expression is a variable (or a nested property of a variable) then it needs to be nil initialized, to make sure that the variable exists at the local scope. However, when the output element expression refers to the loopCounter variable, then it shouldn't overwrite this variable. Note that the loopCounter is already created at the local scope. This adds a test case that fails if the output element variable is nil initialized when it refers to the loopCounter variable. (cherry picked from commit ffd9ad2)
Similar to the scenario of the input element variable, if the output element expressions refers to the `loopCounter` variable, then we shouldn't NIL initialize it. (cherry picked from commit 64a4309)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #9947 to
stable/1.3.relates to #4687