Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hsts age rule #3827

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Remove hsts age rule #3827

merged 1 commit into from
Jul 14, 2022

Conversation

FestiveKyle
Copy link
Collaborator

@FestiveKyle FestiveKyle commented Jun 24, 2022 •
edited
Loading

Remove HSTS age rule as it is not required.

Closes #3742

lcampbell2
lcampbell2 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@lcampbell2 lcampbell2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
We should add in a neutral tag with the best practice for HSTS age as well

@FestiveKyle FestiveKyle merged commit a84caad into master Jul 14, 2022
@FestiveKyle FestiveKyle deleted the remove-hsts-age-rule branch July 14, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcampbell2 lcampbell2 lcampbell2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should not mark domains with HSTS max age < 1 year as fail
2 participants
@FestiveKyle @lcampbell2