Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle improper max_age directive #4478

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Handle improper max_age directive #4478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b8a4aa
Handle improper max_age directive
FestiveKyle Apr 18, 2023
6811951
Clean up
FestiveKyle Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scanners/web-processor/web_processor/web_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,10 @@ def check_https_downgrades(connections):
"preload": preload
}

hsts_status = "pass" if hsts and max_age > 0 and "https14" not in negative_tags else "fail"
if hsts and isinstance(max_age, int) and max_age > 0 and "https14" not in negative_tags:
hsts_status = "pass"
else:
hsts_status = "fail"

http_down_or_redirect = not http_live or http_immediately_upgrades

Expand Down