Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up transaction calls #4578

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Clean up transaction calls #4578

merged 2 commits into from
Jun 8, 2023

Conversation

FestiveKyle
Copy link
Collaborator

Fix async callback which was not awaited (remove async, not required).

Remove transactions steps wrapped in Promise.all(), steps cannot be run concurrently.

@FestiveKyle FestiveKyle merged commit 77ec970 into master Jun 8, 2023
19 checks passed
@FestiveKyle FestiveKyle deleted the clean-up-transaction-calls branch June 8, 2023 15:33
@FestiveKyle FestiveKyle mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcampbell2 lcampbell2 lcampbell2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FestiveKyle @lcampbell2