WASM: Temporarily rollback on wasm-opt dependency for release builds …

…to make it work on some lg TVs

After testing at large scale our `MULTI_THREAD` feature, we noticed that
some LG and samsung TVs had issues running it.

The problem in question was due to an unrecognized WebAssembly Op Code by
the device linked to the "sign-extensions" proposal
(https://github.com/WebAssembly/sign-extension-ops/blob/master/proposals/sign-extension-ops/Overview.md)
which was not introduced initially with the so-called "WebAssembly MVP"
(the initial release of WebAssembly).

It turns out that rustc (the Rust compiler) targets a WebAssembly
version that is a little further than the MVP by default (it seems that
this decision is actually taken by the LLVM project from what I
understand from an answers in
rust-lang/rust#109807) and amongst
the included features is the sign-extensions feature (so the rest of
included feature is totally unclear and I could not find any resource on
the web listing them.

From there, I was able to remove the sign-extensions Op Code from the
built WebAssembly file by doing either one of these two ways:

  1. Through a rustc flag (`-C target-feature=-sign-ext`). It should be
     noted that the inclusion of this flag prints a warning notice
     indicating that the flag is "unstable"

     Interestingly, a `-C target-cpu=mvp` flag, which looks like it is
     exactly what we want, is also listed in that page yet it doesn't
     seem to remove the sign-extensions opcode for me.

     Maybe because it takes an already-compiled stdlib and the
     problematic opcode is from there? We could re-build stdlib through
     another flag but this latter one is marked as "unstable" so I
     didn't want to adventure too far into this theory and I didn't
     either understand why the other flag would have an effect in that
     case.

  2. By adding the `--signext-lowering` flag to binaryen's wasm-opt tool
     which is documented at:

     > lower sign-ext operations to wasm mvp and disable the sign
     > extension feature

     That solution is nice but I couldn't rely on that flag with the
     [binaryen npm module](https://www.npmjs.com/package/binaryen)
     we now rely on (because RxPlayer developers most likely have
     npm installed so it was seen as a simpler dependency in the
     project than binaries brought by a binaryen project that has
     to be installed separately).

     This means that to add this feature, I have to bring back the full
     `binaryen` package as a dependency of the RxPlayer which isn't
     nice.

Even with its drawbacks, I chose to go with the second solution here
because I was afraid due to its warning notice, the fact that the other
rustc flag (-C target=mvp) didn't have the expected effect and the hint
that this might not work when the feature is in stdlib. We may come back
to this in the future.

Still, this only fix the issue with the `sign-extensions` opcode, and
not the real larger issue which is to either properly handle all devices
supporting WebAssembly or to be able to detect and fallback when a
device fails to compile it.

This hypotetical scenario (for now, though may be more common in the
future), will be handled in a future PR.

It only acts on that feature. Future WebAssembly builds could
break if other new features are not handled by the device.

.github/workflows/checks.yml

@@ -69,6 +69,7 @@ jobs:
         toolchain: stable
     # needed for integration & memory tests codecs support
     - run: sudo add-apt-repository multiverse && sudo apt update && sudo apt install -y ubuntu-restricted-extras
+    - run: sudo apt-get -y install binaryen
     - run: npm install
     - run: rustup target add wasm32-unknown-unknown
     - run: npm run build

package.json

@@ -95,19 +95,45 @@
   },
   "typesVersions": {
     "*": {
-      "experimental": ["./dist/es2017/experimental/index.d.ts"],
-      "experimental/features": ["./dist/es2017/experimental/features/index.d.ts"],
-      "experimental/features/embeds": ["./dist/es2017/__GENERATED_CODE/index.d.ts"],
-      "experimental/features/*": ["./dist/es2017/experimental/features/*.d.ts"],
-      "experimental/tools": ["./dist/es2017/experimental/tools/index.d.ts"],
-      "experimental/tools/*": ["./dist/es2017/experimental/tools/*/index.d.ts"],
-      "features": ["./dist/es2017/features/list/index.d.ts"],
-      "features/*": ["./dist/es2017/features/list/*.d.ts"],
-      "logger": ["./dist/es2017/log.d.ts"],
-      "minimal": ["./dist/es2017/minimal.d.ts"],
-      "tools": ["./dist/es2017/tools/index.d.ts"],
-      "tools/*": ["./dist/es2017/tools/*/index.d.ts"],
-      "types": ["./dist/es2017/public_types.d.ts"]
+      "experimental": [
+        "./dist/es2017/experimental/index.d.ts"
+      ],
+      "experimental/features": [
+        "./dist/es2017/experimental/features/index.d.ts"
+      ],
+      "experimental/features/embeds": [
+        "./dist/es2017/__GENERATED_CODE/index.d.ts"
+      ],
+      "experimental/features/*": [
+        "./dist/es2017/experimental/features/*.d.ts"
+      ],
+      "experimental/tools": [
+        "./dist/es2017/experimental/tools/index.d.ts"
+      ],
+      "experimental/tools/*": [
+        "./dist/es2017/experimental/tools/*/index.d.ts"
+      ],
+      "features": [
+        "./dist/es2017/features/list/index.d.ts"
+      ],
+      "features/*": [
+        "./dist/es2017/features/list/*.d.ts"
+      ],
+      "logger": [
+        "./dist/es2017/log.d.ts"
+      ],
+      "minimal": [
+        "./dist/es2017/minimal.d.ts"
+      ],
+      "tools": [
+        "./dist/es2017/tools/index.d.ts"
+      ],
+      "tools/*": [
+        "./dist/es2017/tools/*/index.d.ts"
+      ],
+      "types": [
+        "./dist/es2017/public_types.d.ts"
+      ]
     }
   },
   "keywords": [
@@ -132,7 +158,7 @@
     "build:dev": "./scripts/generate_build.mjs --dev-mode",
     "build:all": "npm run build:wasm:release && npm run bundle && npm run bundle:min && npm run build",
     "build:wasm:debug": "mkdir -p dist && cd ./src/parsers/manifest/dash/wasm-parser && cargo build --target wasm32-unknown-unknown && cp target/wasm32-unknown-unknown/debug/mpd_node_parser.wasm ../../../../../dist/mpd-parser.wasm",
-    "build:wasm:release": "mkdir -p dist && cd ./src/parsers/manifest/dash/wasm-parser && cargo build --target wasm32-unknown-unknown --release && node ../../../../../scripts/wasm-optimize.mjs target/wasm32-unknown-unknown/release/mpd_node_parser.wasm ../../../../../dist/mpd-parser.wasm && cd ../../../../../ && npm run wasm-strip",
+    "build:wasm:release": "mkdir -p dist && cd ./src/parsers/manifest/dash/wasm-parser && cargo build --target wasm32-unknown-unknown --release && wasm-opt target/wasm32-unknown-unknown/release/mpd_node_parser.wasm --signext-lowering --strip-dwarf -O4 -o ../../../../../dist/mpd-parser.wasm",
     "bundle": "webpack --progress --config webpack.config.mjs --env production",
     "bundle:min": "webpack --progress --config webpack.config.mjs --env minify --env production",
     "bundle:min:watch": "webpack --progress --config webpack.config.mjs -w --env production --env minify",
@@ -191,7 +217,6 @@
     "@typescript-eslint/parser": "6.16.0",
     "arraybuffer-loader": "1.0.8",
     "babel-loader": "9.1.3",
-    "binaryen": "116.0.0",
     "chai": "4.3.10",
     "core-js": "3.34.0",
     "esbuild": "0.19.10",

src/parsers/manifest/dash/wasm-parser/README.md

@@ -251,12 +251,13 @@ fear that they may change in the future, in which case this documentation could
 easily be outdated.
 
 To be able to call those scripts, you will need to have the Rust compiler
-toolchain installed and ready to compile to WebAssembly.
+toolchain installed and ready to compile to WebAssembly as well as `binaryen`, a
+WebAssembly-specialized toolbox.
 
-To do this, the easiest way would be to rely on `rustup`, a tool to install and
-update Rust toolchains:
+There are several ways this can be done, with the easiest way generally being:
 
-  1. Install [rustup](https://rustup.rs/)
+  1. Install [rustup](https://rustup.rs/), which is a tool intended to
+     facilitate the installation of Rust toolchains
 
   2. Install and rely on the stable toolchain:
      ```sh
@@ -268,4 +269,6 @@ update Rust toolchains:
      rustup target add wasm32-unknown-unknown
      ```
 
+  4. Now install [binaryen](https://github.com/WebAssembly/binaryen)
+
 That should be it!