Skip to content

Commit

Permalink
Merge pull request #1372 from canalplus/fix/remove-sign-extensions-fe…
Browse files Browse the repository at this point in the history
…atures

WASM: Temporarily rollback on wasm-opt dependency for release builds to make it work on some LG + Samsung TVs
  • Loading branch information
peaBerberian committed Feb 5, 2024
2 parents fee73d0 + 631ff14 commit baf0e8e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 85 deletions.
17 changes: 0 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@
"@typescript-eslint/parser": "6.16.0",
"arraybuffer-loader": "1.0.8",
"babel-loader": "9.1.3",
"binaryen": "116.0.0",
"chai": "4.3.10",
"core-js": "3.34.0",
"esbuild": "0.19.10",
Expand Down
63 changes: 0 additions & 63 deletions scripts/wasm-optimize.mjs

This file was deleted.

11 changes: 7 additions & 4 deletions src/parsers/manifest/dash/wasm-parser/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -251,12 +251,13 @@ fear that they may change in the future, in which case this documentation could
easily be outdated.

To be able to call those scripts, you will need to have the Rust compiler
toolchain installed and ready to compile to WebAssembly.
toolchain installed and ready to compile to WebAssembly as well as `binaryen`, a
WebAssembly-specialized toolbox.

To do this, the easiest way would be to rely on `rustup`, a tool to install and
update Rust toolchains:
There are several ways this can be done, with the easiest way generally being:

1. Install [rustup](https://rustup.rs/)
1. Install [rustup](https://rustup.rs/), which is a tool intended to
facilitate the installation of Rust toolchains

2. Install and rely on the stable toolchain:
```sh
Expand All @@ -268,4 +269,6 @@ update Rust toolchains:
rustup target add wasm32-unknown-unknown
```

4. Now install [binaryen](https://github.com/WebAssembly/binaryen)

That should be it!

0 comments on commit baf0e8e

Please sign in to comment.