[WIP] Add a promise priotizer #1030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achrafl0
added
the
enhancement
peaBerberian
requested changes
Dec 7, 2021
There was a problem hiding this comment.
I don't get how either form of "cancels" are implemented:
- I don't see how removing a waiting or pending task from the scheduler could be performed by the caller.
- I don't see how temporarily cancelling a low priority task is performed by the scheduler.
I see a call to.cancel()but it doesn't seem link to anything.
achrafl0
commented
Dec 16, 2021
|
Its commits have been cherry-picked in #1158, squashed and merged into |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.