Release/v3.30.0 #1223
Merged
Release/v3.30.0 #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is a necessary stepping stone for multiple projects in parallel:
1. First it is part of the ongoing long-term project of reducing
(removing?) our depency to the RxJS library - mainly to improve the
code's approachability and debuggability.
It has been here completely removed from the `src/core/init`
directory.
2. As it also provides a simple interface to the logic of what
was called previously the `Init`, it also greatly facilitates the
implementation of running the RxPlayer's core in a WebWorker if
wanted (basically: in another thread), while still allowing to run
everything in main by default.
Originally only a proof-of-concept, it's a path that appears more
and more credible to improve the situation seen with some
applications (regarding rebuffering avoidance with low-latency
contents, smoothness of UI interactions when parsing huge MPDs,
better bandwidth calculations and other subjects that could profit
from a player running concurrently to the UI).
This PR simplifies this work by allowing the definition of multiple
now-called `ContentInitializer`: the one already-defined for main
thread buffering, and another one, spawning a WebWorker, for the
worker flavor. It appears that (unsurprisingly), the `Init` was the
almost-only place where this split needs to be done ("almost"
because text track rendering and [in some
case](https://chromestatus.com/feature/5177263249162240) MSE APIs,
also need to be performed in the main thread).
The selection of the right one could be performed as late as load
time.
3. Provide an elegant solution for the previously weird
MediaSource/Directfile paths.
Previously, they were each linked to different functions found
in the `init` directory, with no apparent structure.
Now, they both are `ContentInitializer` implementations, just with
different constructor parameters.
4. Clean-up and provide some structure to the `init` directory.
The work has been huge and need extensive testing and re-reading (I
intent to re-check everything multiple times!), so it may stay as a PR
for some time and I don't plan for now to merge it until the next
release has been, uh, released.
This commit adds handling of the `endNumber` attribute found on some DASH contents, which is the number the last segment should have. We decided to add it after seeing it used in the wild, most notably by some of Canal+ partners. This attribute is only present in newer 2019+ DASH specifications we funnily enough did not have access to until now. It was not in the latest DASH-IF specification neither.
[WIP] Refactor the whole Init into a ContentInitializer concept
…preference handling
… error never being received
This commit adds the `updateContentUrls` API allowing to update at any time and during playback, the URL through which a content's Manifest is reached. This may be used anytime an application prefer a new Manifest URLs to be used, whether it is because the previous URL will soon expire, because the new URL is seen as more qualitative or to rebalance load. The first argument given to `updateContentUrls` is actually an array of strings, listing new URLs from the most prioritized to the least prioritized. This is not used for now, but should soon be used to define fallback URLs when former one fail to fetch the resource. `updateContentUrls` can be given a second argument named `refreshNow` which can be used to ask the RxPlayer to refresh immediately the Manifest behind the given URL. For now, this API will throw for directfile contents, I'm not sure whether it is pertinent to enable it also in this case.
DASH: Now handle `endNumber` DASH attribute
DASH: implement forced-subtitles
Add `updateContentUrls` API
peaBerberian
force-pushed
the
release/v3.30.0
branch
2 times, most recently
from
1da08b9
to
6925454
Compare
…-diagnostic Update demo pages after sonarcloud diagnostic
Wait 4 seconds before restarting streams after receiving a QuotaExceededError
peaBerberian
force-pushed
the
release/v3.30.0
branch
from
6925454
to
9685486
Compare
peaBerberian
force-pushed
the
release/v3.30.0
branch
from
9685486
to
c9ca781
Compare
peaBerberian
force-pushed
the
release/v3.30.0
branch
from
d336ee1
to
329beeb
Compare
Support Panasonic 2019 TVs
We recently noticed an issue on the PS5 which causes stuttering playback on live contents. After exchanging with Sony, turns out the root cause is that their new WebKit version has performance troubles in its segment data eviction logic when the current `MediaSource`'s duration is set at a high value. For live contents, we set in most cases (there are rare exceptions) the duration to 2^32, because higher values may cause issues on other platforms (most notably Tizen). To us, it didn't seem as a very high value but Sony actually advised us to use positive `Infinity` instead (a valid IEEE 754 value that can be set in JavaScript for a "Number"), as it seems to be handled specially by WebKit. `Infinity` is also the actual value advised by the current HTML living standard for live contents, but I was still afraid that just changing to that special value would break other platforms - as we're used to random bugs when changing those types of properties. Because of this, and despite the fact that the issue seems rooted in a WebKit version, I chose to only set the `Infinity` duration on the PS5 for now as this is the only device where that issue has been seen for now.
peaBerberian
force-pushed
the
release/v3.30.0
branch
from
329beeb
to
93fd05e
Compare
Set `Infinity` as duration when playing live contents on the PS5
peaBerberian
force-pushed
the
release/v3.30.0
branch
from
93fd05e
to
d1fda49
Compare
…PS5" This reverts commit 5a39311.
peaBerberian
force-pushed
the
release/v3.30.0
branch
from
d1fda49
to
20947e5
Compare
…superior to calculated duration
peaBerberian
force-pushed
the
release/v3.30.0
branch
from
20947e5
to
759f7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the future v3.30.0 release that we're currently testing
Changelog
Features
updateContentUrlsAPI, allowing to update the Manifest's URL during playback [AddupdateContentUrlsAPI #1182]forcedproperty to the audio tracks API and selecting by default a forced text track linked to the audio track's language if present [DASH: implement forced-subtitles #1187]getKeySystemConfigurationmethod to the RxPlayer [Add thegetKeySystemConfigurationmethod to the RxPlayer #1202]DEBUG_ELEMENTfeature andcreateDebugElementmethod to render a default debugging HTML element [[Proposal] add DEBUG_ELEMENT feature and correspondingcreateDebugElementexperimental method #1200]Deprecated
getVideoLoadedTimemethod which can be easily replaced (see Deprecated method documentation)getVideoPlayedTimemethod which can be easily replaced (see Deprecated method documentation)transportOptions.aggressiveModeoptionkeySystems[].onKeyStatusesChangecallback as no good use case was found for it.Bug fixes
textTrackElement[TTML: set default font size for ttml subtitles on parent element #1191]NO_PLAYABLE_REPRESENTATION[Fix race condition leading to a JS error instead of a NO_PLAYABLE_REPRESENTATION #1201]loadVideoon all WebOS (LG TV) platforms to work around issues [Generalize the renewal of MediaKeys for WebOS #1188]Other improvements
endNumberDASH attribute [DASH: Now handleendNumberDASH attribute #1186]MediaErrorwith theBUFFER_FULL_ERRORcode [Wait 4 seconds before restarting streams after receiving a QuotaExceededError #1221]