Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4 new API methods #1248

Merged
merged 8 commits into from Jun 13, 2023
Merged

Add 4 new API methods #1248

merged 8 commits into from Jun 13, 2023

Conversation

AxMannessiez
Copy link
Collaborator

  • isContentLoaded(): Returns true if a content is loaded.
  • isRebuffering(): Returns true if the player is rebuffering.
  • isPaused(): Returns true if the content is not currently playing.
  • getLastStoredContentPosition(): Get the last stored content position, in seconds.

- isContentLoaded()
- isRebuffering()
- isPaused()
- getLastStoredContentPosition()
src/core/api/public_api.ts Outdated Show resolved Hide resolved
src/core/api/public_api.ts Outdated Show resolved Hide resolved
src/core/api/public_api.ts Outdated Show resolved Hide resolved
@peaBerberian
Copy link
Collaborator

Nice, we now only need to add its documentation in doc/api and doc/reference (I may also do it when I have the time) and maybe to add some simple tests in tests/integration as most should be pretty straightforward to test.

@peaBerberian peaBerberian modified the milestones: 3.30.1, 3.31.0 May 16, 2023
src/core/api/public_api.ts Outdated Show resolved Hide resolved
src/core/init/media_source_content_initializer.ts Outdated Show resolved Hide resolved
doc/reference/API_Reference.md Outdated Show resolved Hide resolved
doc/api/Playback_Information/.docConfig.json Show resolved Hide resolved
@peaBerberian peaBerberian changed the base branch from master to next June 13, 2023 16:14
@peaBerberian peaBerberian merged commit 24d0a1d into next Jun 13, 2023
4 checks passed
@peaBerberian peaBerberian mentioned this pull request Jun 13, 2023
@peaBerberian peaBerberian deleted the feat/new-api-methods branch July 6, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants