PS5: wait for a readyState of 4 before considering the content loaded
#1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that on a PlayStation 5, an
HTMLMediaElement'sreadyStateproperty can switch to3even if the content is encrypted and its decryption key hasn't be obtained yet.This is unusual (we usually encounters a
readyStateof1in that case) and perhaps not compliant to the WHATWG HTML5 standard. More importantly, it might cause the RxPlayer to switch to theLOADEDstate too soon, before switching to aBUFFERINGstate until the key is obtained (whereas it is expected that the RxPlayer can play immediately after reaching theLOADEDstate).Thankfully, a simple work-around can be applied on this case: we know that on the PlayStation 5, we'll always reach a
readyStateof4as soon as we can play the content.We thus rely, only on the PlayStation 5 for now, on the
readyStatebeing set to4before announcing the content asLOADED.