DASH: Fix track duplication when merging more than one switchable AdaptationSet #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptationSet The RxPlayer merge together multiple DASH AdaptationSet with similar characteristics and a two-ways `"adaptation-set-switching"` SupplementalProperty into a single track, as this is a trick often used to make a single "track" linked to several key ids compliant with the DASH-IF IOP while still allowing navigating between the two freely through adaptive bitrate mechanisms. I noticed that, because of a forgotten `break;` call, we could have duplicate tracks if at least 3 AdaptationSet where "switchable" (with the duplicate being the last one encountered each time). This is not a huge deal, as the video track has in any case less priority, and is still a playable track, but it was still unwanted. This is now fixed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RxPlayer merge together multiple DASH AdaptationSet with similar characteristics and a two-ways
"adaptation-set-switching"SupplementalProperty into a single track, as this is a trick often used by packagers to make a single "track" linked to several key ids compliant with the DASH-IF IOP while still allowing navigating between the two freely through adaptive bitrate mechanisms.I noticed that, because of a forgotten
break;call, we could have duplicate tracks if at least 3 AdaptationSet where "switchable" (with the duplicate being the last one encountered each time).This is not a huge deal, as the video track has in any case less priority, and is still a playable track, but it was still unwanted.
This is now fixed.