Fix theoretical memory leak on reload in stream PlaybackObserver creation code #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
commented
Sep 25, 2023
| @@ -445,13 +445,14 @@ export default class MediaSourceContentInitializer extends ContentInitializer { | |||
| } | |||
| }, { clearSignal: cancelSignal, emitCurrentValue: true }); | |||
|
|
|||
| const streamObserver = createStreamPlaybackObserver(manifest, | |||
| playbackObserver, | |||
| const streamObserver = createStreamPlaybackObserver(playbackObserver, | |||
There was a problem hiding this comment.
NOTE: I also changed a little that function's parameters which mixes objects and values without a very clear reason.
…tion code When working on the WebWorker branch (#1272), I noticed a (small) memory leak where a created PlaybackObserver could still be running after a reload for the same content, whereas it should not. This removes that leak by ensuring all logic is cleaned-up on each reload. However, we do have memory-leak tests checking for leaks in that area and it didn't find anything, running the corresponding test before and after the commit is applied seems to result in roughly the same JS heap size. We may have to look if the test does not do what we want it to do or if the leak in question is very insignifance/does not apply in our current code.
peaBerberian
force-pushed
the
fix/stream-playback-observer-memory-leak
branch
from
b3f3a1b
to
52890df
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the WebWorker branch (#1272), I noticed a (small) memory leak where a created PlaybackObserver could still be running after a reload for the same content, whereas it should not.
This removes that leak by ensuring all logic is cleaned-up on each reload.
However, we do have memory-leak tests checking for leaks in that area and it didn't find anything, running the corresponding test before and after the commit is applied seems to result in roughly the same JS heap size. We may have to look if the test does not do what we want it to do or if the leak in question is very insignificant/does not apply in our current code.