Deprecate image buffer feature #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1287, I deprecated the `NATIVE_TEXT_BUFFER` and `HTML_TEXT_BUFFER` as they already are automatically included when importing one of the corresponding text track parsers (so there's no point to have a separate import here, it can just be lazily added on any of those parser's injection to the RxPlayer). Yet I forgot that the exact same situation was there for the `IMAGE_BUFFER` (and even completely forgot to re-document image-related features). This is now done.
Merged
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
Deprecate image buffer feature
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
Deprecate image buffer feature
peaBerberian
added a commit
that referenced
this pull request
Oct 13, 2023
Deprecate image buffer feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1287, I deprecated the
NATIVE_TEXT_BUFFERandHTML_TEXT_BUFFERas they already are automatically included when importing one of the corresponding text track parsers (so there's no point to have a separate import here, it can just be lazily added on any of those parser's injection to the RxPlayer).Yet I forgot that the exact same situation was there for the
IMAGE_BUFFER(and even completely forgot to re-document image-related features). This is now done.