fix extraction of codecs from smooth streaming manifest #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks much better ! will test it on some of our production stream. |
| @@ -193,6 +203,7 @@ function createSmoothStreamingParser(parserOptions={}) { | |||
| ? parse(q.getAttribute(key)) | |||
| : parse[q.getAttribute(key)]; | |||
| } | |||
| obj["codec"] = extractCodec(q.getAttribute("FourCC") || "", obj); | |||
There was a problem hiding this comment.
- the attribute is
codecs(plural) - this attribute should only exist for audio or video adaptations
|
@jinroh sorry for those silly mistakes, should be ok now. |
| @@ -217,7 +231,10 @@ function createSmoothStreamingParser(parserOptions={}) { | |||
| switch (name) { | |||
| case "QualityLevel": | |||
| const rep = parseQualityLevel(node, profile); | |||
|
|
|||
| if (["video", "audio"].indexOf(type) >= 0) { | |||
There was a problem hiding this comment.
nitpick: (type == "video" || type == "audio") should be sufficient here
|
I have separated audio and video codecs extraction but in audio we need to check fourCC value because of AACH |
|
LGTM. Will merge today. |
|
rebased and squased as d9529db. Thanks @lukaszzdanikowski, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #27