Fix phpmd on default arguments using null

canax · Dec 9, 2019 · 7f0bfcc · 7f0bfcc
1 parent 463bc49
commit 7f0bfcc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/REVISION.md b/REVISION.md
@@ -15,7 +15,7 @@ v2.0.x (2019-11-21)
 
 * Upgrade to phpunit 8 (and rewrite some testcases).
 * Add support to use handlers as a class implementing __invoke.
-* Add route handler support for isInvocableClass and handleAsInvocableClass.
+* Add route handler support for isInvocableClass and handleAsInvocableClass (without support for taking arguments).
 
 
 

diff --git a/src/Route/RouteHandler.php b/src/Route/RouteHandler.php
@@ -31,8 +31,8 @@ class RouteHandler
      * @return mixed as the result from the route handler.
      */
     public function handle(
-        string $method = null,
-        string $path = null,
+        ?string $method,
+        ?string $path,
         $action,
         array $arguments = [],
         ContainerInterface $di = null
@@ -224,8 +224,8 @@ protected function handleAsInvocableClass(string $class)
      * @return array with callable details.
      */
     protected function isControllerAction(
-        string $method = null,
-        string $path = null,
+        ?string $method,
+        ?string $path,
         string $class
     ) {
         $method = ucfirst(strtolower($method));