ci: overhaul test data #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
previously approved these changes
Apr 19, 2023
|
|
||
| def pytest_collection_modifyitems(items): | ||
| """Modify test items in place to ensure test modules run in a given order. | ||
| When creating new test modules, be sure to add them here. |
There was a problem hiding this comment.
I had thought in a different project we made a check to ensure len(MODULE_ORDER) == len(# of files that start with test_)
There was a problem hiding this comment.
Good catch! I think we did that in anyvar.
tests/conftest.py
Outdated
| def test_source_factory(EtlClass: Base): | ||
| if os.environ.get("DISEASE_TEST", "").lower() == "true": | ||
| test_class = EtlClass(db, test_data) # type: ignore | ||
| if EtlClass.__name__ == "Mondo": # type: ignore |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #107 (I have no idea what "update branch protection" was referring to)