Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch ETL module import errors #165

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix: catch ETL module import errors #165

merged 2 commits into from
Nov 7, 2023

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Nov 3, 2023 •
edited

This reflects changes made in a PR on gene from a while back. Instead of raising an exception when ETL dependencies aren't installed, the console displays this message instead:

[ etl-import-fix ⚙ venv] ~/code/disease-normalization % disease_norm_update --sources=mondo                                                                                                                                                                     
***Using Disease Database Endpoint: http://localhost:8001***    
                                                                
Deleting Mondo...                                                                                                                                                                                                                                                
Deleted Mondo in 0.04582 seconds.        
                                                                
Loading Mondo...                                                                                                                
Encountered ModuleNotFoundError attempting to import bioversions. Are ETL dependencies installed?

@jsstevenson jsstevenson marked this pull request as ready for review November 6, 2023 20:55
@jsstevenson jsstevenson added the priority:low Low priority label Nov 6, 2023
@jsstevenson jsstevenson merged commit 8eb2bfb into main Nov 7, 2023
18 checks passed
@jsstevenson jsstevenson deleted the etl-import-fix branch November 7, 2023 21:10
@jsstevenson jsstevenson mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

Assignees
No one assigned
Labels
priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsstevenson @korikuzma