Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add basic route tests #167

Merged
merged 4 commits into from
Nov 10, 2023
Merged

test: add basic route tests #167

merged 4 commits into from
Nov 10, 2023

Conversation

jsstevenson
Copy link
Member

No description provided.

@jsstevenson jsstevenson marked this pull request as ready for review November 7, 2023 21:27
@jsstevenson jsstevenson added the priority:low Low priority label Nov 7, 2023
korikuzma
korikuzma previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we also want to handle cases where required query parameters are missing?

@jsstevenson jsstevenson merged commit ae69876 into main Nov 10, 2023
18 checks passed
@jsstevenson jsstevenson deleted the route-tests branch November 10, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korikuzma korikuzma korikuzma approved these changes

Assignees
No one assigned
Labels
priority:low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsstevenson @korikuzma