Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use OBO release for Mondo #171

Merged
merged 10 commits into from
Dec 4, 2023
Merged

feat!: use OBO release for Mondo #171

merged 10 commits into from
Dec 4, 2023

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Dec 1, 2023

A bit more wordy than I'd have liked, but the OBO source data is muuuuch easier to work with (particularly for test data). Might try to move DO and NCIt over to OBO at another time.

  • Unfortunately, Mondo ingest of GARD and orphanet associations is kinda messed up now. Made Pickier ingest of xrefs/associated_with #172 to follow up. I have tried half a dozen other OBO and OWL libraries and nobody satisfies quite everything, but this was the best move in the moment IMO.
  • Noticed while working on this that the base class isn't doing as many quality checks as in the other normalizers. Left it as is and made Refine Base.load_disease() #173 to continue on it. This is why there are some weird changes to aliases in the test data.

@jsstevenson jsstevenson marked this pull request as ready for review December 4, 2023 15:01
korikuzma
korikuzma previously approved these changes Dec 4, 2023
prefix = NamespacePrefix[xref.id.prefix.upper()]
except KeyError:
_logger.warning(f"Unrecognized namespace: {xref.id.prefix}")
print(xref)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(xref)

@jsstevenson jsstevenson merged commit 8b7c35b into main Dec 4, 2023
18 checks passed
@jsstevenson jsstevenson deleted the mondo-obo branch December 4, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants