Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure consistent source meta schema typing #175

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

jsstevenson
Copy link
Member

close #174

I'm actually not sure what this error is or how you're getting it -- but I did notice that there is a weird place where we're using a dict but probably shouldn't be, so maybe that's it? lmk

@jsstevenson jsstevenson requested review from korikuzma and removed request for korikuzma December 19, 2023 19:30
@jsstevenson jsstevenson marked this pull request as ready for review December 19, 2023 19:31
@jsstevenson jsstevenson added the priority:low Low priority label Dec 19, 2023
korikuzma
korikuzma previously approved these changes Dec 20, 2023
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and bump version

@jsstevenson jsstevenson merged commit 355a587 into main Dec 20, 2023
18 checks passed
@jsstevenson jsstevenson deleted the schema-fix branch December 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected SourceMeta but got dict - serialized value may not be as expected
2 participants