Staging #84
Staging #84
Conversation
…ntic refactor: disease_id --> disease
Pipfile
Outdated
| requests = "*" | ||
| typing-extensions = "*" | ||
| bioversions = "*" |
There was a problem hiding this comment.
Should these all be in dev packages? I'm also not sure if typing-extensions is needed.
There was a problem hiding this comment.
Also, do you wanna bump the disease version to 0.2.16
setup.cfg
Outdated
| boto3 | ||
| requests | ||
| typing-extensions | ||
| ga4gh.vrsatile.pydantic >= 0.1.dev3 |
There was a problem hiding this comment.
It's in above
| ga4gh.vrsatile.pydantic >= 0.1.dev3 |
setup.cfg
Outdated
| @@ -35,6 +35,20 @@ dev = | |||
| click | |||
| owlready2 | |||
| rdflib | |||
| boto3 | |||
There was a problem hiding this comment.
It's in above
| boto3 |
Pipfile
Outdated
| @@ -23,4 +23,7 @@ pydantic = "*" | |||
| fastapi = ">=0.72.0" | |||
| uvicorn = "*" | |||
| boto3 = "*" | |||
| requests = "*" | |||
There was a problem hiding this comment.
Can we also move click to required packages here and in setup.cfg? This was a mistake on my part. 🤦♀️
There was a problem hiding this comment.
@jsstevenson there's still some unresolved suggestions, like the boto3 in both dev + required packages in setup.cfg. I don't think they need to be in both, but let me know if I'm wrong
build: use latest version of ga4gh.vrsatile.pydantic
|
@jsstevenson ugh I didn't think about my merge affecting your PR. ga4gh.vrsatile.pydantic needs to pin 0.0.11 again. Sorry 😭 |
disease/version.py
Outdated
| @@ -1,2 +1,2 @@ | |||
| """Disease normalizer version""" | |||
| __version__ = "0.2.15" | |||
| __version__ = "0.3.0" | |||
disease/schemas.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| from enum import Enum, IntEnum | |||
| from pydantic import BaseModel, StrictBool | |||
| from datetime import datetime | |||
| from ga4gh.vrsatile.pydantic.vrsatile_models import ValueObjectDescriptor | |||
| from ga4gh.vrsatile.pydantic.vrsatile_models import DiseaseDescriptor | |||
There was a problem hiding this comment.
Change back to ValueObjectDescriptor. Will need to do this in the other places (tests I believe)
Co-authored-by: Kori Kuzma <42851808+korikuzma@users.noreply.github.com>
Co-authored-by: Kori Kuzma <42851808+korikuzma@users.noreply.github.com>
No description provided.