Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: separate out etl (dev) dependencies on main #142

Merged
merged 1 commit into from
Oct 18, 2022
Merged

build: separate out etl (dev) dependencies on main #142

merged 1 commit into from
Oct 18, 2022

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Oct 18, 2022 •
edited

Addresses main branch task for #141

  • Packages in gene/etl are now part of dev dependencies
    • Moved vrs_locations inside gene/etl since they are only used during the ETL methods
    • Removed unused packages
  • Pins ga4gh.vrsatile.pydantic + ga4gh.vrs so that metaschema updates are not included
  • Updates readme for pip/pipenv/seqrepo
  • Fixed seqrepo key error (this was already addressed in Handle unrecognized accession identifiers #123 in staging)

@korikuzma korikuzma self-assigned this Oct 18, 2022
@korikuzma korikuzma changed the title build: separate out etl (dev) dependencies build: separate out etl (dev) dependencies on main Oct 18, 2022
jsstevenson
jsstevenson approved these changes Oct 18, 2022
View reviewed changes
Pipfile Show resolved Hide resolved
@korikuzma korikuzma merged commit 89a5149 into main Oct 18, 2022
@korikuzma korikuzma deleted the issue-141 branch October 18, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korikuzma @jsstevenson