-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: expand base template and improve descriptions #209
Conversation
@jsstevenson what's the priority on this PR? |
@korikuzma very low |
@@ -0,0 +1,22 @@ | |||
Sources | |||
======= | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might make more sense to move the Gene record summary over to this page, and put GeneDescriptor on the normalization page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even having sections for search, normalize, and normalize_unmerge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only requesting change for the seqrepo path because I think it was a typo. This is coming together quite nicely! I do agree it would be nice to have a little section about VRS and how we support different versions
requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not part of this issue, but you can remove the requirements in this PR if you want. Or we can do it in a separate issue
@@ -0,0 +1,22 @@ | |||
Sources | |||
======= | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even having sections for search, normalize, and normalize_unmerge?
This PR covers a few documentation-related aspirations
Also we can close #185, close #206
A few discussion points/possible todo's:
btw, PRs should now trigger new readthedocs builds, so you can check out how this would look here: https://gene-normalizer--209.org.readthedocs.build/en/209/