Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: modernize build configs #271

Merged
merged 18 commits into from
Oct 3, 2023
Merged

build: modernize build configs #271

merged 18 commits into from
Oct 3, 2023

Conversation

jsstevenson
Copy link
Member

@jsstevenson jsstevenson commented Oct 2, 2023

  • Use the "src" layout instead of a "flat" layout. It is argued that this is better: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/
  • Move build settings into pyproject.toml. People seem to think this is more "modern". At the very least, it means fewer files for us to manage. Removed some deprecated settings while in here.
  • Add a few additional PyPI classifiers.
  • Update default test command options (they were showing their age)

@jsstevenson jsstevenson changed the title build: configure setuptools in pyproject.toml build: modernize build configs Oct 2, 2023
@jsstevenson jsstevenson marked this pull request as ready for review October 2, 2023 14:59
@korikuzma
Copy link
Member

@jsstevenson what's the priority?

@jsstevenson
Copy link
Member Author

@korikuzma new rule if we (I) forget to mark a priority then we (you) consider it to be very low

@jsstevenson jsstevenson added the priority:low Low priority label Oct 2, 2023
authors = [
{name = "Alex Wagner"},
{name = "Kori Kuzma"},
{name = "James Stevenson"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THE James

korikuzma
korikuzma previously approved these changes Oct 3, 2023
@jsstevenson jsstevenson merged commit 0d7b0ec into staging Oct 3, 2023
21 checks passed
@jsstevenson jsstevenson deleted the pyproject branch October 3, 2023 12:23
jsstevenson added a commit that referenced this pull request Oct 3, 2023
* Use the "src" layout instead of a "flat" layout. It is argued that this is better: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/
* Move build settings into `pyproject.toml`. People seem to think this is more "modern". At the very least, it means fewer files for us to manage. Removed some deprecated settings while in here.
* Add a few additional PyPI classifiers.
* Update default test command options (they were showing their age)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants