Implemented load to the firenado launcher.

Added the load to the launch app run task also. Fixes: #243
candango · Dec 1, 2018 · f184fdf · f184fdf
1 parent b89bb6d
commit f184fdf
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/firenado/management/tasks.py b/firenado/management/tasks.py
@@ -126,6 +126,7 @@ def run(self, namespace):
 
         app_type = firenado.conf.app['types'][firenado.conf.app['type']]
         launcher = get_class_from_config(app_type['launcher'])(**parameters)
+        launcher.load()
         launcher.launch()
 
 

diff --git a/firenado/tornadoweb.py b/firenado/tornadoweb.py
@@ -56,6 +56,9 @@ def __init__(self, addresses=None, dir=None, port=None):
             os.chdir(self.dir)
             reload(firenado.conf)
 
+    def load(self):
+        return None
+
     def launch(self):
         return None
 
@@ -187,23 +190,23 @@ class TornadoLauncher(FirenadoLauncher):
     def __init__(self, addresses=None, dir=None, port=None):
         super(TornadoLauncher, self).__init__(addresses, dir, port)
         self.http_server = None
+        self.application = None
         self.MAX_WAIT_SECONDS_BEFORE_SHUTDOWN = firenado.conf.app[
             'wait_before_shutdown']
 
-    def launch(self):
-        import signal
-
+    def load(self):
         # TODO: Resolve module if doesn't exists
         if firenado.conf.app['pythonpath']:
             sys.path.append(firenado.conf.app['pythonpath'])
+        self.application = TornadoApplication(debug=firenado.conf.app['debug'])
 
+    def launch(self):
+        import signal
         signal.signal(signal.SIGTERM, self.sig_handler)
         signal.signal(signal.SIGINT, self.sig_handler)
         if os.name == "posix":
             signal.signal(signal.SIGTSTP, self.sig_handler)
-        self.application = TornadoApplication(debug=firenado.conf.app['debug'])
-        self.http_server = tornado.httpserver.HTTPServer(
-            self.application)
+        self.http_server = tornado.httpserver.HTTPServer(self.application)
         if firenado.conf.app['socket']:
             from tornado.netutil import bind_unix_socket
             socket = bind_unix_socket(firenado.conf.app['socket'])

diff --git a/tests/tornadoweb_test.py b/tests/tornadoweb_test.py
@@ -20,7 +20,7 @@
 import firenado.conf
 from firenado.tornadoweb import TornadoApplication
 from firenado.tornadoweb import TornadoHandler
-from firenado.tornadoweb import FirenadoLauncher
+from firenado.tornadoweb import FirenadoLauncher, TornadoLauncher
 from firenado.tornadoweb import TornadoComponent
 import unittest
 from tests import chdir_app
@@ -137,3 +137,9 @@ def test_parameters_set(self):
         self.assertEqual(addresses, launcher.addresses)
         self.assertEqual(dir, launcher.dir)
         self.assertEqual(port, launcher.port)
+
+    def test_load(self):
+        chdir_app('tornadoweb')
+        launcher = TornadoLauncher()
+        launcher.load()
+        self.assertTrue(isinstance(launcher.application, TornadoApplication))