Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move random_string to the security module. #247

Closed
piraz opened this issue Dec 1, 2018 · 0 comments
Closed

Move random_string to the security module. #247

piraz opened this issue Dec 1, 2018 · 0 comments
Assignees
@piraz
Labels
refactory security util
Milestone
firenado 0.1.7.5

Comments

@piraz
Copy link
Contributor

piraz commented Dec 1, 2018

Lets move random_string from util to the security module.

The first problem here is related to the fact that random_string is declared into the util's init.py.

As this random function is being used for security purposes, it makes sense to plate it at security.

By now we gonna keep a depreciated random_string reference at the same place to don't break dependencies and removed it at 0.1.8.x.
@piraz piraz added this to the firenado 0.1.7.5 milestone Dec 1, 2018
@piraz piraz self-assigned this Dec 1, 2018
piraz added a commit to piraz/firenado that referenced this issue Dec 13, 2018
@piraz
Used secrets to generate the string if python is greater than 3.6.
cbbd9bf 
Refs: candango#247
piraz added a commit to piraz/firenado that referenced this issue Dec 21, 2018
@piraz
Moved random cookie to the random namespace.
4b016ac 
Changed the command name to random string and added radom uuid to
the namespace.

Refs: candango#247
@piraz piraz closed this as completed in 513c8d7 Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piraz piraz

Labels
refactory security util
Projects
None yet
Milestone
firenado 0.1.7.5
Development

No branches or pull requests
1 participant
@piraz