Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply 'go fmt' Style #135

Merged
merged 3 commits into from Dec 4, 2018
Merged

Apply 'go fmt' Style #135

merged 3 commits into from Dec 4, 2018

Conversation

jcburley
Copy link
Contributor

@jcburley jcburley commented Dec 3, 2018

Just scratching an itch....

@jcburley
Copy link
Contributor Author

jcburley commented Dec 3, 2018

Oddly, docs/joker.string.html also gets changed by this PR; was it not regenerated via the most recent (December) release?

Please let me know if you want me to remove that change from this PR.

@candid82
Copy link
Owner

candid82 commented Dec 4, 2018

Thanks! Yes, I forgot to run generate-std.joke when releasing. I'll add it to release.joke.

@candid82 candid82 merged commit ddb253e into candid82:master Dec 4, 2018
@jcburley jcburley deleted the gofmt branch December 4, 2018 03:10
@candid82
Copy link
Owner

candid82 commented Dec 4, 2018

@jcburley looks like you forgot to commit the change in generate-std.joke that prefixes the variables with _. Was there a particular reason for that change?

@jcburley
Copy link
Contributor Author

jcburley commented Dec 4, 2018

Sorry, I was juggling two different branches and hadn't intended for that underscore-prefixing to leak out of the gostd2joker branch I've been working on.

Let me check into that after submitting this next PR (adding an eval-test script).

@jcburley
Copy link
Contributor Author

jcburley commented Dec 4, 2018

I guess master is actually in okay shape due to upstream regeneration of the pertinent files, thankfully.

Anyway, the change is needed if someone adds an API that has an argument named c, res, or whatever might be "reserved" to generate-std.joke.

That's a theoretical issue until my gostd2joker picks up all sorts of APIs (via automation), when there can be (and have been) actual collisions.

The change I have pending, on the gostd2joker branch, should fix this.

Might put fixing that stuff in a separate PR, to "shard" the big gostd2joker PR I've been working on into easier-to-understand-and-swallow PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants