Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve std/generate-std.joke Script #137

Merged
merged 2 commits into from Dec 7, 2018

Conversation

jcburley
Copy link
Contributor

@jcburley jcburley commented Dec 4, 2018

Avoid conflicts between argument names and internally-generated (reserved) names by prefixing the reserved names with single underscores. (There might be a better approach to this that could be used; this assumes APIs won't use underscore-prefixed argument names., which might be an erroneous assumption.)

Support docstrings with embedded backticks. (Needed by gostd2joker work, but a reasonable thing to do now.)

Support multi-level namespaces, e.g. joker.go.net. (Needed by gostd2joker work, but a reasonable thing to do now.)

Optionally comment out Go code for "empty" packages. (Wanted for gostd2joker work in the past; not sure it'll be needed going forward.)

@jcburley
Copy link
Contributor Author

jcburley commented Dec 4, 2018

Maybe I should bring some of my run.sh changes over from the gostd2joker branch (as a distinct PR)?

@candid82
Copy link
Owner

candid82 commented Dec 7, 2018

Thanks!
RE: run.sh changes. Looks like you call generate-docs and generate-std in your version. I was hesitant to do that because I thought it was not necessary most of the time and it would slow down the build, but perhaps the overhead is negligible (seems to be less than half a second). Feel free to send a PR.

@candid82 candid82 merged commit 0aff202 into candid82:master Dec 7, 2018
@jcburley jcburley deleted the generate-std-fixes branch December 7, 2018 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants