RFC : completely remove flash-as-eeprom emulation for get/set_USER_ID #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a pair of USB requests ( GS_USB_BREQ_GET_USER_ID and _SET_USER_ID) that is not supported by the linux driver, and not used by any known software : candle-usb#91 Since the firmware returns a unique serial #, there doesn't appear to be any use case for assigning a user ID. Using a whole flash page for that purpose can be wasteful on bigger targets . This removes all the relevant code and adjusts the linker scripts accordingly.
|
I've yet to see the value in it. totally unsupported in linux as far as I can tell. |
|
@HubertD , any thoughts on this ? |
|
Go ahead, remove that code. The firmware provides proper device unique serial numbers via the USB interface directly. |
Yes, I'm just not sure why Hubert went through the trouble of adding a settable user_id ... Eh, I can always revert the removal if something pops up. But I think it won't be missed. |
|
Rebase + merged in a0caf93 . |
This was referenced Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to the discussion in #91 .
Any thoughts ? There's no rush to delete probably-good code, but if it's not used by anyone...
This would remove all the relevant code and adjusts the linker scripts accordingly.