gs_usb: document switchable termination support #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2022
ammarfaizi2
pushed a commit
to ammarfaizi2/linux-fork
that referenced
this pull request
Sep 23, 2022
The candleLight community is working on switchable termination support for the candleLight firmware. As the the Linux CAN framework supports switchable termination add this feature to the gs_usb driver. Devices supporting the feature should set the GS_CAN_FEATURE_TERMINATION and implement the GS_USB_BREQ_SET_TERMINATION and GS_USB_BREQ_GET_TERMINATION control messages. For now the driver assumes for activated termination the standard termination value of 120Ω. Link: https://lore.kernel.org/all/20220923074114.662045-1-mkl@pengutronix.de Link: candle-usb/candleLight_fw#92 Link: candle-usb/candleLight_fw#109 Link: candle-usb/candleLight_fw#108 Cc: Daniel Trevitz <daniel.trevitz@wika.com> Cc: Ryan Edwards <ryan.edwards@gmail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde
force-pushed
the
termination
branch
from
1a95691
to
8ffc053
Compare
marckleinebudde
force-pushed
the
termination
branch
from
8ffc053
to
151ec30
Compare
|
Support for switchable termination has been added to the linux-net-next tree and will be mainline with Linux v6.1. |
fenugrec
reviewed
Oct 5, 2022
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the switchable termination support which will be added to the Linux driver soon. For the current Linux driver patch see: https://lore.kernel.org/all/20220918211802.692405-1-mkl@pengutronix.de/
This PR fixes issue #92
A reference implementation for switchable termination is added to the candleLight firmware in PR #108.