Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new features: Bus Error Reporting and query device state #124

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Document new features: Bus Error Reporting and query device state #124

merged 2 commits into from
Nov 5, 2022

Conversation

marckleinebudde
Copy link
Contributor

No description provided.

@marckleinebudde
gs_usb.h: document GS_CAN_MODE_BERR_REPORTING
ad2f13a 
In commit
torvalds/linux@1f18352
[1] Bus Error Reporting has been added to the Linux driver. Document
this bit here accordingly.

The new feature ("GS_CAN_FEATURE_BERR_REPORTING") indicates that the
bus error reporting in the CAN controller can switched on and off with
the GS_CAN_MODE_BERR_REPORTING mode bit in the GS_USB_BREQ_MODE
control message.

[1] https://git.kernel.org/torvalds/c/1f1835264d81da03fcd05646542a622678b379d6
@marckleinebudde
gs_usb.h: document GS_CAN_FEATURE_GET_STATE, GS_USB_BREQ_GET_STATE
2bba52f 
In commit
torvalds/linux@40e1997
[1] GS_CAN_FEATURE_GET_STATE has been added to the Linux driver.
Document this bit here accordingly.

The new feature ("GS_CAN_FEATURE_GET_STATE") indicates that the state
of the CAN controller can be queried with the new
GS_USB_BREQ_GET_STATE control message.

[1] https://git.kernel.org/torvalds/c/40e1997d4551e6053fc2f61959628da474775dc5
@fenugrec
Copy link
Collaborator

fenugrec commented Nov 1, 2022

looks good.
I'm having a hard time following the process between the posts with submitted patches on linux-can mailing list, and eventual merge in linux trunk... unlike a PR here, there isn't an obvious trace of a patchset being accepted/approved , merged by whoever's in charge of linux-can, and then eventual merge into trunk...

@marckleinebudde
Copy link
Contributor Author

In the Linux kernel new CAN features go via the linux-can-next tree to the net-next-tree and during the merge window into Linus's tree. I'm responsible for the linux-can-next tree. Once patches are in net-next they will hit mainline. The patches to document these features are net-next and will be in the v6.2 release of Linux.

@jhofstee
Copy link
Contributor

jhofstee commented Nov 4, 2022

And for what it is worth, I have the changes to implement it as well, but that waits for the fixes for the error-reporting to be merged first.

@fenugrec
Copy link
Collaborator

fenugrec commented Nov 4, 2022

but that waits for the fixes for the error-reporting to be merged first.

Do you mean #119 or the kernel changes ?

@jhofstee
Copy link
Contributor

jhofstee commented Nov 4, 2022

I meant #119 indeed, I wasn't aware it is merged. Sorry for that, but I get thousand of notifications a day, missed it somehow. I will rebase the implementation on top of this.

@fenugrec fenugrec merged commit 2bba52f into candle-usb:master Nov 5, 2022
@marckleinebudde marckleinebudde deleted the new-features branch November 6, 2022 10:02
@marckleinebudde marckleinebudde mentioned this pull request Jan 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marckleinebudde @fenugrec @jhofstee