Added mode to pad output usb packets to 32 bytes for better WinUSB performance #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfink-christ
pushed a commit
to pfink-christ/net-next
that referenced
this pull request
Nov 29, 2021
Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde
added a commit
to marckleinebudde/linux
that referenced
this pull request
Nov 29, 2021
The widely used open source firmware candleLight supports padding the USB packets to max packet size to improve performance on Windows systems. This patch documents this bit. Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
pfink-christ
pushed a commit
to pfink-christ/net-next
that referenced
this pull request
Dec 9, 2021
Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde
added a commit
to marckleinebudde/linux
that referenced
this pull request
Dec 10, 2021
The widely used open source firmware candleLight supports padding the USB packets to max packet size to improve performance on Windows systems. This patch documents this bit. Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde
added a commit
to marckleinebudde/linux
that referenced
this pull request
Feb 3, 2022
The widely used open source firmware candleLight supports padding the USB packets to max packet size to improve performance on Windows systems. This patch documents the bit. Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde
added a commit
to marckleinebudde/linux
that referenced
this pull request
Feb 4, 2022
The widely used open source firmware candleLight supports padding the USB packets to max packet size to improve performance on Windows systems. This patch documents the bit. Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde
added a commit
to marckleinebudde/linux
that referenced
this pull request
Feb 6, 2022
The widely used open source firmware candleLight supports padding the USB packets to max packet size to improve performance on Windows systems. This patch documents the bit. Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
marckleinebudde
added a commit
to marckleinebudde/linux
that referenced
this pull request
Feb 15, 2022
The widely used open source firmware candleLight supports padding the USB packets to max packet size to improve performance on Windows systems. This patch documents the bit. Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 10, 2022
The widely used open source firmware candleLight supports padding the USB packets to max packet size to improve performance on Windows systems. This patch documents the bit. Link: https://lore.kernel.org/all/20220309124132.291861-12-mkl@pengutronix.de Link: candle-usb/candleLight_fw#7 Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, on some motherboards under windows, WinUsb will only allow you to receive one packet per 1khz usb frame from a client unless the packet size is the maximum for the bulk input pipe. These changes add a mode that pads output packets fron the client to that maximum with zeroes. The firmware defaults to the old behavior unless this mode bit is set, and seems to still work OK under Linux. I created a companion pull request for your candle_dll windows driver that has a test program that is able to receive over 2k packets per second.