Support volume restrictions on file:// urls, update SQLite URL support for it
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for applying
Volumerestrictions toUrlresources if the URL is afile://URL.The only notable side effect is that SQLite DB URLs must now use the
file://scheme vs the customsqlite://scheme. This is to avoid setting the precedent of some URL schemes pointing to files internally.This PR also adds support for SQLite in-memory databases which can be enabled with the URL
sqlite://memory(since it's special-by-default and doesn't point to any real resource). The errors thrown in either case point the user to the right syntax when possible.