DRAFT Add web support #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtokman
requested changes
Jun 20, 2023
Comment on lines
+12
to
+14
| // TODO can blurTintColor get implemented on Web? | ||
| // TODO can colorTintOpacity get implemented on Web? | ||
| // TODO can scale get implemented on Web? How would it work? |
There was a problem hiding this comment.
The blurTintColor is a view beneath the blur that we can add as a child here and default its opacity to 0 and its background color to transparent, which will just use a light blur. Same with the colorTintOpacity, it works on the view when the tint color is set.
I included it to allow using more than light and dark which are the only two options on iOS. It allows you to pick any color and achieve a similar effects to this:
CleanShot.2023-06-20.at.08.34.28.mp4
Comment on lines
+15
to
+16
| // Lastly: if we want reanimated support for the blurRadius, I wonder if it'd work out of the box, or if we need a reanimated implementation in here. | ||
| return <View style={[style, blurEnabled && { filter: `blur(${blurRadius}px)` }]} {...props} /> |
There was a problem hiding this comment.
I haven't used reanimated on web, if it's 1:1 with mobile, wrapping this in an Animated.create... should work. I included an example of that for iOS in the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition for web support. Here's a snack playground. It's possible
filter: 'saturation()'orhue-rotateoropacity()could be used to implement the color props.