Translate few error messages #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'throw' will raise a synchronous exception which bypasses all the error handling based on defer/promises, triggering an "Ooops!" error window of cockpit, and leaving an in-progress register dialog. Instead, use the standard defer/promise error handling done in other parts of the registerSystem() function already, so the error message will be properly shown as inline error in the register dialog.
Reword the text of some untranslated error messages to be more "elegant", for example with the proper spelling of "IPv6" & "URL", and by removing the ellipsis (which fit "in progress" messages). Also, use the gettext function to properly translate them. This fixes the cockpit parts of https://bugzilla.redhat.com/show_bug.cgi?id=2076914
|
(mostly) self-note: I think this should fix all the untranslated messages in the cockpit plugin itself; as reported in rhbz#2076914, the other ones come from other sources (sub-man & candlepin). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reword the text of some untranslated error messages to be more
"elegant", for example with the proper spelling of "IPv6" & "URL",
and by removing the ellipsis (which fit "in progress" messages).
Also, use the gettext function to properly translate them, and make sure to use a proper error handling based on JS promises (like already used) rather than throwing raw messages (which cockpit display only as "Ooops" window).
This fixes the cockpit parts of
https://bugzilla.redhat.com/show_bug.cgi?id=2076914
Card ID: ENT-4943