Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1185958: Make ostree plugin depend on ostree. #1234

Merged
merged 1 commit into from Aug 10, 2015

Conversation

alikins
Copy link
Contributor

@alikins alikins commented Jul 29, 2015

No description provided.

@wottop
Copy link
Member

wottop commented Jul 30, 2015

Requires ostree for tito build to succeed.

@wottop wottop self-assigned this Jul 31, 2015
@alikins
Copy link
Contributor Author

alikins commented Aug 4, 2015

pastebin of tito errors?

[subscription-manager]$ rpm -qa | grep ostree
[subscription-manager]$ tito build --test --rpm

Works for me

@wottop
Copy link
Member

wottop commented Aug 6, 2015

Is the ostree plugin supposed to not get build if ostree is not installed or is it supposed to error on the tito build?

On 7.2 nightly:
rpm -qa | grep ostree
subscription-manager-plugin-ostree-1.16.0-1.git.43.4ce326b.el7.x86_64

on tito build -i --rpm --test
########## ERROR ############
Error running command: sudo rpm -Uvh --force /tmp/tito/x86_64/subscription-manager-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-plugin-ostree-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-plugin-container-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-gui-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-initial-setup-addon-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-migration-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-debuginfo-1.16.0-1.git.3.13004a0.el7.x86_64.rpm
Status code: 1792
Command output: error: Failed dependencies:
ostree is needed by subscription-manager-plugin-ostree-1.16.0-1.git.3.13004a0.el7.x86_64
Traceback (most recent call last):
File "/usr/bin/tito", line 5, in
pkg_resources.run_script('tito==0.5.6', 'tito')
File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 540, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 1462, in run_script
exec_(script_code, namespace, namespace)
File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 41, in exec_
exec("""exec code in globs, locs""")
File "", line 1, in
File "/usr/lib/python2.7/site-packages/tito-0.5.6-py2.7.egg/EGG-INFO/scripts/tito", line 23, in

File "build/bdist.linux-x86_64/egg/tito/cli.py", line 225, in main
File "build/bdist.linux-x86_64/egg/tito/cli.py", line 391, in main
File "build/bdist.linux-x86_64/egg/tito/builder/main.py", line 143, in run
File "build/bdist.linux-x86_64/egg/tito/builder/main.py", line 294, in _auto_install
File "build/bdist.linux-x86_64/egg/tito/common.py", line 303, in run_command
tito.exception.RunCommandException: Error running command: sudo rpm -Uvh --force /tmp/tito/x86_64/subscription-manager-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-plugin-ostree-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-plugin-container-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-gui-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-initial-setup-addon-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-migration-1.16.0-1.git.3.13004a0.el7.x86_64.rpm /tmp/tito/x86_64/subscription-manager-debuginfo-1.16.0-1.git.3.13004a0.el7.x86_64.rpm

@awood
Copy link
Contributor

awood commented Aug 7, 2015

@wottop The plugin should always be built. In the error you posted, it looks like it's an error in the -i portion of Tito. I.e. the package built but can't install because ostree is missing.

@wottop
Copy link
Member

wottop commented Aug 10, 2015

@awood, good call.

ack

wottop added a commit that referenced this pull request Aug 10, 2015
…_req_ostree

1185958: Make ostree plugin depend on ostree.
@wottop wottop merged commit f61cc92 into master Aug 10, 2015
@wottop wottop deleted the alikins/1185958_ostree_plugin_req_ostree branch August 10, 2015 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants